algorithm-deps-install #1081
algorithm-deps-install #1081
Conversation
add python support
|
/deploy |
|
/deploy |
There was a problem hiding this comment.
Reviewed 18 of 20 files at r1, 2 of 2 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yehiyam)
core/api-server/lib/service/builds.js, line 225 at r4 (raw file):
dependencyInstallCmd
You can add a test for that, just copy a test from tests/algorithms-store.js with:
"a build was triggered due to"
There was a problem hiding this comment.
Reviewable status: 20 of 21 files reviewed, 1 unresolved discussion (waiting on @nassiharel)
core/api-server/lib/service/builds.js, line 225 at r4 (raw file):
Previously, NassiHarel (Nassi Harel) wrote…
dependencyInstallCmdYou can add a test for that, just copy a test from tests/algorithms-store.js with:
"a build was triggered due to"
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r5.
Reviewable status:complete! all files reviewed, all discussions resolved
* add dependencyInstallCmd option to algorithm add python support * add nodejs support * fix install deps script permission * add test .... bump version [skip ci]
* add dependencyInstallCmd option to algorithm add python support * add nodejs support * fix install deps script permission * add test .... bump version [skip ci]
This change is